-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/es module support #38
base: master
Are you sure you want to change the base?
Conversation
tsconfig-base.json
Outdated
|
||
"compilerOptions": { | ||
"lib": ["es2020"], | ||
"module": "commonjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes indeed
you may want to change the base to feature/typescript-support to make the diff a bit cleaner. Github will automatically update the base when the other PR is merged |
Indentation changes make it harder to read this PR, regardless of whether or not they should be executed at all. Is the change in the import statements something that end-users will notice too? We see the import changed from |
The |
as per discussion in the chat, this is confirmed by https://nodejs.org/api/esm.html#mandatory-file-extensions . As such we should consider this a breaking feature |
as per further discussion with @MikiDi, I think we could restore/support the old behaviour with babel using this plugin: https://www.npmjs.com/package/babel-plugin-add-import-extension |
If a breaking change is happening with the node 18 bump anyways, would it make sense to include this as well? More and more packages are switching to ESM-only publishing setups. |
This still would need some work then, right (swapping target to |
(I've opened #63 to discuss the implications and the plan forward.) |
Adds support for the installation of es modules in your project.